This repository was archived by the owner on Feb 12, 2024. It is now read-only.
refactor: convert dag API to async/await#2664
Merged
alanshaw merged 2 commits intoDec 16, 2019
Merged
Conversation
dirkmc
approved these changes
Dec 13, 2019
Contributor
dirkmc
left a comment
dirkmc
left a comment
There was a problem hiding this comment.
One nit but otherwise LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future we might need a
DAGServicelike go-ipfs to break the circular dependency.TODO: fix in
ipfs-http-clientipfs-inactive/js-ipfs-http-client#1183 - BREAKING CHANGE:dag.resolveanddag.treenow return an async iterable